Commit 9db27320 authored by Allan Sandfeld Jensen's avatar Allan Sandfeld Jensen
Browse files

Fix double LoadFinished on URL errors


RenderFrameDeleted was called before DidFinishLoad, which meant
m_loadingErrorFrameList was empty and wouldn't detect the page loaded
was an error page. Instead this patch relies on the chromium error-page
url which we already asserted.

Additonally we delay emitting the loadFinished signal until the error
page is also done loading, since the error-page can be considered part
of the load, and we otherwise have a race condition on toPlainText.

Finally we were not getting error-pages when blocking requests because
we reported them as aborted them instead of blocked.

Change-Id: I945eb838b7f080d4e146f18354e8986e1b88b5cd
Task-number: QTBUG-50752
Reviewed-by: default avatarMichael Brüning <michael.bruning@theqtcompany.com>
Showing with 58 additions and 7 deletions
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment