WebContentsAdapter is not created together with the QQuickWebEngineView.
Thus querying a view property can lead to a crash if it uses the adapter.
This fix adds the missing guards for contentSize and scrollPosition
as it is done for similar WebEngineView properties.

Task-number: QTBUG-65942
Change-Id: I9c2668a059b08325629f5730608280ba7f3669cf
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>

Avoid unnecessary unselect calls to prevent to lose active focus on an
input field during background load.

Task-number: QTBUG-64082
Change-Id: I13e8e2a96254360a78329d6ea2b6858da86a2b5a
Reviewed-by: Viktor Engelmann <viktor.engelmann@qt.io>

Note that the Referer header still won't be sent if the download is triggered
via an anchor element with the 'download' attribute: crbug.com/455987 .

Task-number: QTBUG-61354
Change-Id: I5af971af916b2190756e3e58f19736072a213922
Reviewed-by: Michal Klocek <michal.klocek@qt.io>

When one searches for text on one page and then navigates away,
results for the search-term are also highlighted on the new page.
To stop this from happening, we now call adapter->stopFinding()
when we navigate away from a page.

Task-number: QTBUG-61506
Change-Id: I09e064d7788b12eae0a67c01e4f5872d94924617
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>

With the no-accessibility feature moved to qtgui-config, we don't
always include it where web_content_apapter_client.h is included, which
gives it an inconsistent binary layout.

Solve it by making the optional method always defined as it doesn't
rely on anything from accessibility.

Task-number: QTBUG-61200
Change-Id: I65f34ab2b6763f3166b945e700994bd8d019a835
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>

We were returning the PDF byte-data as a javascript unicode string using
the deprecated ascii cast constructor.

This patch changes the behavior to match that of runJavaScript callbacks
and uses a script value over QVariant.

[ChangeLog][QtWebEngine] The callback version of WebEngineView::printToPdf
is now called with a proper bytearray result instead of PDF byte data
in a javascript string.

Change-Id: I71565623465c54052568bb5ff34665baaa93e187
Reviewed-by: Michal Klocek <michal.klocek@qt.io>

When opening a new window, for example by using the JavaScript
method window.open('...'), the requested url is not stored
in the content::WebContents object we get in
WebContentsDelegateQt::createWindow (at this point, it should
at least be stored as pending request in the WebContents'
NavigationController, but it is not).

Because of this, the QQuickWebEngineNewViewRequest object
in QQuickWebEngineViewPrivate::adoptNewWindow never contained
the url. We have access to the target url in
WebContentsDelegateQt::WebContentsCreated, so now we store
it there in a new property m_initialTargetUrl, from where
WebContentsDelegateQt::createWindow takes it and passes it
to WebContentsAdapter::adoptNewWindow as a new parameter.

[ChangeLog][WebEngine] Fix WebEngineNewViewRequest::requestedUrl being empty when opening window from JavaScript

Task-number: QTBUG-57675
Change-Id: I7e2c7866899baade17ce2517e6be8b2b2709699e
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>

The standard context menu currently doesn't have the "Follow link" item for e.g.
the image links on https://www.qt.io

 .

Change-Id: I5b9d620135c7a8e65bd95a0ab07a76278e56cad0
Reviewed-by: Michal Klocek <michal.klocek@qt.io>

Rename to follow our standard naming. This class was one of our oldest
and probably predates our standard naming convention.

Change-Id: I32dfbad9611b789ad13114d9692b07045806f7c0
Reviewed-by: Michal Klocek <michal.klocek@qt.io>

Use Custom Dialog API instead of Test Support API for testing form
validation messages. Moreover, remove the form validation part from the
Test Support API.

Change-Id: I8ecc80745ddad26f90df413d9a1d04045512af6c
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>

In the destructor of QWebEnginePage and QQuickWebEngineView, we
now call adapter->stopFinding() to suppress callbacks that would
cause segmentation faults if a findText request is still active
at that point.

Task-number: QTBUG-58563
Change-Id: I9d5d8407ee6c28cd76bf6ecf0b62808394e151cd
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Reviewed-by: Michal Klocek <michal.klocek@qt.io>

Now the users can create user scripts when they are working
with QQuickWebEngineProfiles in C++.

Change-Id: I6ada78b1fc44c3f93589eb468578c330a1be9c6f
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>

Like in the widgets API we must check the result of updateDragPosition
and ignore or accept the QDragMoveEvent.

Task-number: QTBUG-58037
Change-Id: I26b9e10460eb2840c45698d9444c15ed78c6a1b3
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>

Currently printing and pdf are bounded together. Make compilation
optional by adding it as a feature.

Fix formatting of embedded_linux.pri

Task-number: QTBUG-57731
Task-number: QTBUG-58108
Change-Id: I53a2baea656df0a5b6139365ed06385c9ebc5830
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>

[ChangeLog][Important Changes] Printing to a PDF file will now emit
signal the signal pdfPrintingFinished in both QQuickWebEngineView
and QWebEnginePage.

The boolean passed with the signal to indicate if the printing and
saving of the PDF was successful. The path of the created file is
also passed to enable the user to map the signal to a print request.

Task-number: QTBUG-56677
Change-Id: Ifab5a20b048f33a8cd872165bd4d453b01708037
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>

Added Q_PROPERTY and getter for
QQuickWebEngineNewViewRequest::m_requestedUrl
so that it can be read from QML.

Task-number: QTBUG-55590
Change-Id: I39e89690f996a1db7c9ce39103429186b26811f8
Reviewed-by: Michael Brüning <michael.bruning@qt.io>

Wrap unused parameters.

Change-Id: Iac550783a55b3fc585db6f7b8241aa2ae89fdf2e
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>

Change-Id: Ic200807246c5feb8e1f33215cbc6194b03765359
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>

This moves the actual printing using QPrinter to the WebEngineWidgets
part of the API.
The printsupport module depends on the widgets module and therefore
QtWebEngineCore also had a dependency to widgets. This is removed by
this change.

Change-Id: If6e5745709a59de18f2123b930cbe6e64390c867
Reviewed-by: Michal Klocek <michal.klocek@qt.io>

Removes RequestType prefix from FormValidationMessageRequest's
RequestType enumeration members.

Change-Id: I51b7eb77b0bae2a8d3109e3ee3b7ea42349b211c
Reviewed-by: Kai Koehne <kai.koehne@qt.io>

Task-number: QTBUG-56092
Change-Id: I026a0d153269a71e4e44f0fd30ef5ca054edd0e7
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>

The src/core/renderer directory is meant to contain files that would be
in the renderer process and the chrome/renderer subdirectory in chromium,
but a few classes from the browser process and the renderer_host dir
has snuck in.

This patch cleans up the structure so that classes in the browser that
serves as host classes for renderer classes goes in renderer_host.

Change-Id: I9333b1322e2246d4da9b4e8cfe6be604f6d996bf
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>

When a link triggers a NewViewRequest, and the latter creates
a new window with a new WebEngineView inside, the "adapter" pointer
can still be NULL when the adoptWebContents is called by openIn.
Therefore is it necessary to test the adapter pointer before using it.

(cherry picked from commit bfc2683a

)
Task-number: QTBUG-55765
Change-Id: Iaa7cb4e8c7780a2e3f1a8c85b7b5da0ec541b2f3
Reviewed-by: Jani Heikkinen <jani.heikkinen@qt.io>

QtWebEngine.experimental import is not working. It is better to
get rid of that.
It also removes some QNX-specific code.

Change-Id: If80c1290b4d5f5e4d436c49bd7d7a6ea882ee6db
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>

When a link triggers a NewViewRequest, and the latter creates
a new window with a new WebEngineView inside, the "adapter" pointer
can still be NULL when the adoptWebContents is called by openIn.
Therefore is it necessary to test the adapter pointer before using it.

Task-number: QTBUG-55765
Change-Id: Ia1a299dd65c229705462c9444b81d7b26567fc09
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>

Introduce qml APIs to support custom context menus.

[ChangeLog][QtWebEngine][QML] Added ability to show custom
context menu.

Task-number: QTBUG-52554
Change-Id: Ief0cbbbf221f4c6849e16bbba7417dccee59ad61
Reviewed-by: Kai Koehne <kai.koehne@qt.io>

Introduce qml APIs to support custom dialogs:
 * http and proxy authentication
 * javascript dialogs
 * file pickers
 * color pickers
 * form validation messages

[ChangeLog][QtWebEngine][QML] Added ability to provide custom dialogs
for HTTP and proxy authentication, JavaScript alerts, file and color
picking, and form validation messages.

Task-number: QTBUG-51190
Change-Id: I559ca59264750feb36ba7d3dba0bf0647509306d
Reviewed-by: Kai Koehne <kai.koehne@qt.io>

QtQuickControls1 does not handle embedded
platforms too well. In case of eglfs platform
we crash badly - only one window is supported.
QtQuickControls2 on the other hand lacks the native
look on desktop. Therefore on desktop platforms
keep using QtQuickControls1, and on eglfs use
QtQuickControls2.

QtQuick.Dialogs are not implemented for QtQuickControls2,
moreover required authentication dialog and prompt
dialog are neither implemented in QtQuickControls1.
As a workaround  make new dialogs to give
consistent look and feel.

Replace close() with reject() signal in java script
prompt dialog to unify handling between qqc1 and qqc2

[ChangeLog][QtWebEngine][General] Qt WebEngine (QML)
now optionally uses Qt Quick 2 Controls to show standard dialogs.

Task-number: QTBUG-53467
Task-number: QTBUG-51177
Change-Id: I42f9506357bbb82d4f04465f30a18c8013439e25
Reviewed-by: Kai Koehne <kai.koehne@qt.io>

[ChangeLog][QtWebEngineQML][QQuickWebEngineView] View Source feature is
now supported
[ChangeLog][QtWebEngineWidgets][QWebEnginePage] View Source feature is
now supported

Change-Id: Icc16da71fc6ec95880897fc9744dd8be8c004e00
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>

The docs do not currently get built, because docs for a QML type
need to reside in one file. Also edited the docs for grammar and
style.

Change-Id: Ic62f293e113d0e4bfe0497ce4a665a2a42971eb3
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>

[ChangeLog][QtWebEngineQML][QQuickWebEngineView] ToolTip
(HTML global title attribute) are now handled.

Task-numner: QTBUG-54108
Change-Id: I78cc3c1e934a822d6399ebd35c8c7895fbdf5749
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>

This reverts commit:
 * d364c05d
 * e507f140



Moreover it fixes shut down of keyed services,
updates versioning of and fixes spellcheck unit
test context menu request, which otherwise
fails on windows.

Change-Id: I9bfc589544cb969abd6d2d7af69531b4c5c907b7
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>

QExplicitSharedDataPointer is meant for value objects, not for shared
objects. Instead switch to using QSharedPointer.

Change-Id: Ib3791bbcfde627a67508f2819e141d8c538a4a50
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
Reviewed-by: Michal Klocek <michal.klocek@theqtcompany.com>

If a user does not handle onCertificateError the
instance of QQuickWebEngineCertificateError never
gets to JavaScript land and never gets deleted.

Create a strong reference before emitting the
onCertificateError to guard against the memory
leak.

Change-Id: I49dbf89445d32291e2f52976f0f5e9deda201fcb
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>

To ensure Chromium is given a chance to handle editor commands,
we must override these short-cuts.

On OS X we must also perform the action afterwards as these are not
handled internally by the Blink Editor.

The patch solves copy/paste in flash plugins and copy/paste on OS X
when no application short-cuts have been defined. The handling of
short-cut override events is based on how it was handled in Qt WebKit

Task-number: QTBUG-54221
Change-Id: I748671c7bfa5662aae16c6a4b9bbe5e2bce1b907
Reviewed-by: Alexandru Croitor <alexandru.croitor@theqtcompany.com>

Suppose QWebEnginePage is destroyed while there's still a combobox popup
open. We would crash with the following stack trace:

1   QtWebEngineCore::RenderWidgetHostViewQt::dpiScale
2   QtWebEngineCore::RenderWidgetHostViewQt::GetViewBounds
3   content::RenderWidgetHostImpl::SendScreenRects
4   content::RenderWidgetHostImpl::OnRenderViewReady
...
16  base::MessageLoop::DoWork
17  WebEngineContext::destroy
18  `anonymous namespace'::destroyContext
19  qt_call_post_routines
20  QApplication::~QApplication

RenderWidgetHostViewQt still holds a pointer to WebContentsAdapterClient.
To fix this, expose the QObject owning the adapter client, and
hide RenderWidgetHostViewQt when it is destroyed so it won't try to render.

Change-Id: Ide5543197b35038a3e1c7491ceda3f5ad10f6f07
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>

If the qml properties audioMuted or recentlyAudible are accessed / set
on a WebEngineView on application startup, the application will crash
due to accessing a null pointer (the web contents adapter is not
allocated yet).

Add guards against null pointer access, to prevent the crash.

Change-Id: I939be9afa093d1889024b2ff9308deb88b9316bf
Reviewed-by: Michael Brüning <michael.bruning@theqtcompany.com>

Qt Quick Controls 1 always creates "native" windows
for popups, however it does not check if the platform
can support creating "native" windows. As a workaround
disable context menu until Qt Quick Controls 2 are
in place.

Task-number: QTBUG-53467
Change-Id: Iea32e19f256f3d7e81a61e23f7da64dfc7ec660d
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>

Currently if a QWebEngineView or a QQuickWebEngineView is disabled
using setEnabled(false), after loading a web page, the views are
automatically focused, and a user might see a blinking caret in an html
input for example, even though the user can't interact with it.

Fix consists in not calling the Focus() method whenever a view is
disabled.

Change-Id: I1014fb5898a5ddf01a4e9b14c3eaf5d4006e5131
Task-number: QTBUG-53159
Reviewed-by: Michal Klocek <michal.klocek@theqtcompany.com>

Spellchecking API needs a bit more reviews and love.
Current API is not intuitive and partly broken.

Change-Id: Ie9cd371f38cca2f6b3f56a8699ad874cd332c318
Reviewed-by: Michael Brüning <michael.bruning@theqtcompany.com>