Commit 7696dcdb authored by Frederik Gladhorn's avatar Frederik Gladhorn
Browse files

Accessibility: Improve roles


Section, Paragraph and WebDocument have been added to qtbase in Qt 5.4.
Change-Id: I6b249caf3af123e3a2c68fb981278f49c86a32ee
Reviewed-by: default avatarAndras Becsi <andras.becsi@digia.com>
Showing with 6 additions and 4 deletions
...@@ -169,7 +169,7 @@ QAccessible::Role BrowserAccessibilityQt::role() const ...@@ -169,7 +169,7 @@ QAccessible::Role BrowserAccessibilityQt::role() const
// for this page, and a web area for a frame within this page. // for this page, and a web area for a frame within this page.
case WebAXRoleWebArea: case WebAXRoleWebArea:
case WebAXRoleRootWebArea: // not sure if we need to make a diff here, but this seems common case WebAXRoleRootWebArea: // not sure if we need to make a diff here, but this seems common
return QAccessible::Document; return QAccessible::WebDocument;
// These roles all directly correspond to blink accessibility roles, // These roles all directly correspond to blink accessibility roles,
// keep these alphabetical. // keep these alphabetical.
...@@ -214,7 +214,7 @@ QAccessible::Role BrowserAccessibilityQt::role() const ...@@ -214,7 +214,7 @@ QAccessible::Role BrowserAccessibilityQt::role() const
case WebAXRoleDisclosureTriangle: case WebAXRoleDisclosureTriangle:
return QAccessible::NoRole; // FIXME return QAccessible::NoRole; // FIXME
case WebAXRoleDiv: case WebAXRoleDiv:
return QAccessible::NoRole; // FIXME return QAccessible::Section;
case WebAXRoleDocument: case WebAXRoleDocument:
return QAccessible::Document; return QAccessible::Document;
case WebAXRoleDrawer: case WebAXRoleDrawer:
...@@ -247,6 +247,8 @@ QAccessible::Role BrowserAccessibilityQt::role() const ...@@ -247,6 +247,8 @@ QAccessible::Role BrowserAccessibilityQt::role() const
return QAccessible::NoRole; // FIXME return QAccessible::NoRole; // FIXME
case WebAXRoleIncrementor: case WebAXRoleIncrementor:
return QAccessible::NoRole; // FIXME return QAccessible::NoRole; // FIXME
case WebAXRoleInlineTextBox:
return QAccessible::EditableText;
case WebAXRoleLabel: case WebAXRoleLabel:
return QAccessible::StaticText; return QAccessible::StaticText;
case WebAXRoleLink: case WebAXRoleLink:
...@@ -286,9 +288,9 @@ QAccessible::Role BrowserAccessibilityQt::role() const ...@@ -286,9 +288,9 @@ QAccessible::Role BrowserAccessibilityQt::role() const
case WebAXRoleOutline: case WebAXRoleOutline:
return QAccessible::NoRole; // FIXME return QAccessible::NoRole; // FIXME
case WebAXRoleParagraph: case WebAXRoleParagraph:
return QAccessible::NoRole; // FIXME return QAccessible::Paragraph;
case WebAXRolePopUpButton: case WebAXRolePopUpButton:
return QAccessible::NoRole; // FIXME return QAccessible::ComboBox;
case WebAXRolePresentational: case WebAXRolePresentational:
return QAccessible::NoRole; // FIXME return QAccessible::NoRole; // FIXME
case WebAXRoleProgressIndicator: case WebAXRoleProgressIndicator:
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment