Commit 066caebd authored by Marc Mutz's avatar Marc Mutz
Browse files

QTranslator: optimize string handling in find_transformation


- Don't repeatedly truncate a (shared) QString, truncate a QStringRef
  instead, preventing a detach.

Change-Id: I1a9cf7fc5bc9ea06279f7e2548f2bd144b8780a3
Reviewed-by: default avatarThiago Macieira <thiago.macieira@intel.com>
Reviewed-by: default avatarOlivier Goffart (Woboq GmbH) <ogoffart@woboq.com>
Reviewed-by: default avatarOswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>
Showing with 2 additions and 1 deletion
......@@ -668,7 +668,8 @@ static QString find_translation(const QLocale & locale,
}
// start guessing
for (QString localeName : qAsConst(fuzzyLocales)) {
for (const QString &fuzzyLocale : qAsConst(fuzzyLocales)) {
QStringRef localeName(&fuzzyLocale);
for (;;) {
int rightmost = localeName.lastIndexOf(QLatin1Char('_'));
// no truncations? fail
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment