Commit 8edfc4e9 authored by Oswald Buddenhagen's avatar Oswald Buddenhagen
Browse files

make zlib_dependency auto-add QtCore as a private dep


our zlib header includes qglobal.h, so we need the qtcore include dirs,
and qtcore is also where the actual code is compiled into.

Change-Id: I09f530a1b4e6160438215a6d7223c0771ce94f05
Reviewed-by: default avatarSimon Hausmann <simon.hausmann@theqtcompany.com>
Showing with 12 additions and 2 deletions
...@@ -13,6 +13,7 @@ load(qt_build_paths) ...@@ -13,6 +13,7 @@ load(qt_build_paths)
TEMPLATE = lib TEMPLATE = lib
CONFIG -= qt CONFIG -= qt
QT = # In case qt is re-added.
CONFIG -= warning_clean # Don't presume 3rd party code to be clean CONFIG -= warning_clean # Don't presume 3rd party code to be clean
load(qt_common) load(qt_common)
......
...@@ -7,4 +7,8 @@ contains(QT_CONFIG, system-zlib) { ...@@ -7,4 +7,8 @@ contains(QT_CONFIG, system-zlib) {
} }
} else { } else {
INCLUDEPATH += $$PWD/zlib INCLUDEPATH += $$PWD/zlib
!no_core_dep {
CONFIG += qt
QT_PRIVATE += core
}
} }
...@@ -158,6 +158,7 @@ else:SOURCES += tools/qelapsedtimer_generic.cpp ...@@ -158,6 +158,7 @@ else:SOURCES += tools/qelapsedtimer_generic.cpp
contains(QT_CONFIG, zlib) { contains(QT_CONFIG, zlib) {
include($$PWD/../../3rdparty/zlib.pri) include($$PWD/../../3rdparty/zlib.pri)
} else { } else {
CONFIG += no_core_dep
include($$PWD/../../3rdparty/zlib_dependency.pri) include($$PWD/../../3rdparty/zlib_dependency.pri)
} }
......
...@@ -132,8 +132,12 @@ macx { ...@@ -132,8 +132,12 @@ macx {
../../corelib/io/qstandardpaths_win.cpp ../../corelib/io/qstandardpaths_win.cpp
} }
if(contains(QT_CONFIG, zlib)|cross_compile):include(../../3rdparty/zlib.pri) contains(QT_CONFIG, zlib)|cross_compile {
else:include(../../3rdparty/zlib_dependency.pri) include(../../3rdparty/zlib.pri)
} else {
CONFIG += no_core_dep
include(../../3rdparty/zlib_dependency.pri)
}
win32:LIBS += -luser32 -lole32 -ladvapi32 -lshell32 win32:LIBS += -luser32 -lole32 -ladvapi32 -lshell32
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment